[QwixOdmlTagPropagation] Fix ODML tag propagation by adding gather and split to _VALUE_PRESERVING_PRIMITIVES.#220
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 26, 2026
Conversation
copybara-service
Bot
force-pushed
the
test_874688434
branch
2 times, most recently
from
f970b09 to
572be0c
Compare
…and `split` to `_VALUE_PRESERVING_PRIMITIVES`. - Removed `Split` class and `jax.lax.split` mapping from `get_all_ops`. The previous implementation intercepted the high-level `jax.lax.split` op. Any other JAX composite that used splitting primitives internally would bypass this class and potentially lose tags. This had caused gemma3 `multiply0_lhs` tagloss issue. PiperOrigin-RevId: 875388000
copybara-service
Bot
force-pushed
the
test_874688434
branch
from
572be0c to
c2c7067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[QwixOdmlTagPropagation] Fix ODML tag propagation by adding
gatherandsplitto_VALUE_PRESERVING_PRIMITIVES.Splitclass andjax.lax.splitmapping fromget_all_ops. The previous implementation intercepted the high-leveljax.lax.splitop. Any other JAX composite that used splitting primitives internally would bypass this class and potentially lose tags. This had caused gemma3multiply0_lhstagloss issue.