🧪 [testing improvement] Add tests for challenge_ts edge cases#613
🧪 [testing improvement] Add tests for challenge_ts edge cases#613
Conversation
Adds tests to ensure the ReCaptcha verification does not incorrectly flag a challenge timeout when `challenge_ts` is either missing or empty. These strings evaluate to false when parsed by `strtotime()`, thereby skipping the challenge timeout check gracefully. Co-authored-by: rowan-m <108052+rowan-m@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
rowan-m
deleted the
jules-testing-improvement-challenge-ts-15921032405317755597
branch
2 participants
🎯 What: This testing improvement adds explicit edge cases to
ReCaptchaTestfor empty or missingchallenge_tsreturned from the API when timeout verification is active.📊 Coverage: Previously, the
invalid-timestampwas tested, but not cases wherechallenge_tsis empty string or completely omitted from the API JSON response, which evaluates tofalsewhen parsing withstrtotime().✨ Result: Enhanced test coverage that verifies edge-cases for missing/empty
challenge_tscorrectly bypass timeout logic without causing false positives.PR created automatically by Jules for task 15921032405317755597 started by @rowan-m