fix: handle packager, vendor and others#88
Conversation
|
Thank you! Quite a conundrum. |
|
Yes, this will unfortunately be a breaking change... |
|
another idea would be to reserve values and use them instead e.g. const NO_EPOCH = ^uint32(0)
if epoch != NO_EPOCH {
// add field
}wdyt? |
|
Ohhhh using 4294967295 .. That's gross; I like it. OK I don't like it, but better it's than the alternative. Can you make the change? Be sure to include the literal 4294967295 in the code comment, and say why we went that route. |
3b4c096 to
6b58821
Compare
|
pushed, let me know what you think! |
6b58821 to
bb35334
Compare
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
bb35334 to
88dec4e
Compare
Packager, vendor, URL, and Epoch are being added to the headers even if they have no value and are not required.
This PR moves them to pointers, and add them if they are non-null values.
Could also not add them if they have their default value, which would not break anyone using the lib, but might be less clear, especially if someone wants to set epoch to 0, for example...
refs goreleaser/nfpm#619