tar2rpm: add filename '-' as an alias for stdin and stdout#94
tar2rpm: add filename '-' as an alias for stdin and stdout#94jarondl merged 1 commit intogoogle:masterfrom
Conversation
jarondl
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I'm not sure I understand the rationale (or indeed the solution). What do you care if some message is printed to stderr? In common practice apps ignore stderr. Can you explain the reasoning?
If this is about some kind of "quietness" or "verbosity", perhaps adding a flag for that would be better than magical behavior difference when you specify "-" or not.
(I'm not saying no to this PR, I just want to understand it better).
|
/gcbrun |
|
This tries to follow the "silence is golden" rule of most (non-Windows) commandline tools, and When no So, in my opinion no |
Sounds good. Please add a notice to |
When no filenames are given the informative message "tar2pm: reading tar content from stdin, writing rpm data to stdout." is printed to stderr. This can be suppressed by explicitly specifying '-' for TARFILE and RPMFILE (if only TAR- or RPMFILE is given the message reflects that). Also updated usage() to reflect that, and rename FILE to TARFILE/RPMFILE.
|
Updated usage, and while writing the text I split the overloaded |
When no filenames are given the informative message
"tar2pm: reading tar content from stdin, writing rpm data to stdout."
is printed to stderr. This can be suppressed by explicitly
specifying '-' for TARFILE and RPMFILE (if only TAR- or RPMFILE is
given the message reflects that).
Also updated usage() to reflect that, and rename FILE to
TARFILE/RPMFILE.