Skip to content

Drop length limit in get_file_contents actions #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panhania merged 2 commits into from
Mar 11, 2026
Merged

Drop length limit in get_file_contents actions #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
278bf4d
Drop length limit in `get_file_contents`.
panhania Mar 10, 2026
5a41306
Drop length limit in `get_file_contents_kmx`.
panhania Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions crates/rrg/src/action/get_file_contents.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,6 @@ impl crate::request::Args for Args {

let len = match proto.length() {
0 => usize::MAX,
len if len > MAX_BLOB_LEN as u64 => {
return Err(ParseArgsError::invalid_field("length", LenError {
len,
}));
}
len => len as usize,
};

Expand Down Expand Up @@ -213,26 +208,6 @@ impl std::fmt::Display for FileErrorKind {
}
}

/// An error indicating that the action was invoked with invalid length.
#[derive(Debug)]
struct LenError {
len: u64,
}

impl std::fmt::Display for LenError {

fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {
write! {
fmt,
"provided length ({}) is bigger than allowed ({})",
self.len, MAX_BLOB_LEN
}
}
}

impl std::error::Error for LenError {
}

#[cfg(test)]
mod tests {

Expand Down
25 changes: 0 additions & 25 deletions crates/rrg/src/action/get_file_contents_kmx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,11 +254,6 @@ impl crate::request::Args for Args {

let len = match proto.length() {
0 => usize::MAX,
len if len > MAX_BLOB_LEN as u64 => {
return Err(ParseArgsError::invalid_field("length", LenError {
len,
}));
},
len => len as usize,
};

Expand Down Expand Up @@ -346,26 +341,6 @@ impl std::fmt::Display for FileErrorKind {
}
}

/// An error indicating that the action was invoked with invalid length.
#[derive(Debug)]
struct LenError {
len: u64,
}

impl std::fmt::Display for LenError {

fn fmt(&self, fmt: &mut std::fmt::Formatter) -> std::fmt::Result {
write! {
fmt,
"provided length ({}) is bigger than allowed ({})",
self.len, MAX_BLOB_LEN
}
}
}

impl std::error::Error for LenError {
}

#[cfg(test)]
mod tests {

Expand Down
Loading