test: stabilize S2FurthestEdgeQuery GetDistance check near Pi#624
Open
abhinavgautam01 wants to merge 3 commits into
Open
test: stabilize S2FurthestEdgeQuery GetDistance check near Pi#624abhinavgautam01 wants to merge 3 commits into
abhinavgautam01 wants to merge 3 commits into
Conversation
jmr
reviewed
May 13, 2026
jmr
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #592
Problem
macOS CI intermittently failed
S2FurthestEdgeQuery.PointCloudEdgeswith:GetDistance()slightly belowexpected_distance - max_error, even though the bulk comparison (CheckDistanceResults) passed.See #592.
Cause
GetDistance()routes throughFindFurthestEdge(), while the reference side runs brute-forceFindFurthestEdges(). Near antipodal distances (~π / chord length near straight), tiny floating-point differences inlength2()can trip a strictEXPECT_GEbound without indicating a real geometric mismatch.Fix
In
TestFindFurthestEdges, compare against:(expected_distance - max_error)widened byPlusError(-slack), where:slack = max( GetUpdateMinDistanceMaxError(expected_distance) + GetUpdateMinDistanceMaxError(expected_distance - max_error), 512 * DBL_EPSILON);This keeps the check tied to documented distance-update error bounds, with a small absolute floor near 180°.
Validation