This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Conversation
Contributor
tburgin
commented
Feb 15, 2019
tburgin
commented
- Use buildifier to format .bzl and BUILD files
- Rename Source/santa-driver -> Source/santa_driver
- Allow to kernel_tests binary to unload the driver after tests
russellhancox
suggested changes
Feb 15, 2019
BUILD
Outdated
| run_command( | ||
| name = "reload", | ||
| srcs = ["//Source/santa-driver"], | ||
| srcs = ["//Source/santa_driver:santa-driver"], |
Contributor
There was a problem hiding this comment.
I'd suggest renaming the rule too, so you don't need to specify it.
russellhancox
previously approved these changes
Feb 15, 2019
russellhancox
approved these changes
Feb 15, 2019
dskfh
pushed a commit
to dskfh/santa
that referenced
this pull request
Jul 17, 2020
* starlark format * Source/santa-driver -> Source/santa_driver * buildifier * kernel_tests unloads the driver * review updates * review updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.