This repository was archived by the owner on Feb 5, 2025. It is now read-only.
santad: remove start and stop options from the sync service queue#803
Merged
Conversation
russellhancox
approved these changes
May 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
startSyncingEventsandstopSyncingEventswere used in SNTDaemonControlController's-[setSyncdListener:]method. This allowed upload requests to wait up to 2 seconds for the now legacy syncd connection to become active. The idea was to smooth out any jitter with the connection. The calls to start and stop event uploading were mistakenly removed in #775, resulting in no santad initiated uploads from taking place. It also means bundle events would never be uploaded.This pull request removes these start and stop options. In reality the jitter mitigation didn't accomplish much. If the syncservice were to crash or hang it will take longer than a few seconds for the connection to be re-established. In that case we would be dropping the event anyways. We are okay with this, the main event is still saved to the events.db and will be uploaded on the next full sync.