Skip to content

Comments

Pylint with Python3.10#92

Merged
kralka merged 5 commits intogoogle:masterfrom
kralka:pylint_with_3_10
Jul 14, 2022
Merged

Pylint with Python3.10#92
kralka merged 5 commits intogoogle:masterfrom
kralka:pylint_with_3_10

Conversation

@kralka
Copy link
Collaborator

@kralka kralka commented Jul 11, 2022

Pylint also with Python3.10. Other workflows (mypy, pytest...) are still run against Python3.9. Suggested at #87 (comment)

@jmichelp Should we also bump Python version for other workflows?

@kralka kralka requested a review from jmichelp July 11, 2022 12:22
@kralka kralka marked this pull request as ready for review July 11, 2022 12:22
@jmichelp
Copy link
Collaborator

Interestingly the workflow name is shortened into "3.1" instead of "3.10".

It depends which python version we use most.
The idea here is to pylint with the all supported versions and one version above so that we can can earlier issues when we bump the version. The other tests should use the python version we currently rely on.

@kralka kralka marked this pull request as draft July 11, 2022 12:45
@kralka
Copy link
Collaborator Author

kralka commented Jul 11, 2022

Interestingly the workflow name is shortened into "3.1" instead of "3.10".

It got parsed as a float.

It depends which python version we use most. The idea here is to pylint with the all supported versions and one version above so that we can can earlier issues when we bump the version. The other tests should use the python version we currently rely on.

I would say we rely on 3.7 (still :/), 3.8 for Ubuntu 20.04LTS, 3.10 for Ubuntu 22.04LTS. While 3.11 is still alpha.

@kralka
Copy link
Collaborator Author

kralka commented Jul 11, 2022

I suggest to bump Python version in workflows to 3.10 and when 3.11 is out to add it to the pylint matrix.

@kralka kralka marked this pull request as ready for review July 11, 2022 13:10
@jmichelp
Copy link
Collaborator

Sounds good.
Going back in versions wouldn't make sense.

Be careful that tensorflow sometimes needs time to fully test a new version of python interpreter. Adding 3.11 too early could result in a missing package.

@kralka
Copy link
Collaborator Author

kralka commented Jul 11, 2022

Adding 3.11 too early could result in a missing package.

Good point, but if that happens the PR fails and we wait a bit more (nothing breaks).

@kralka kralka merged commit 8d7242a into google:master Jul 14, 2022
@kralka kralka deleted the pylint_with_3_10 branch August 24, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants