Support all rule deployment functions #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mihirvala08
reviewed
Sep 10, 2025
This was
linked to
issues
Sep 10, 2025
Collaborator
|
/run-integration-tests 3ef93d4 |
mihirvala08
reviewed
Sep 10, 2025
mihirvala08
reviewed
Sep 10, 2025
mihirvala08
requested changes
Sep 10, 2025
Collaborator
mihirvala08
left a comment
mihirvala08
left a comment
There was a problem hiding this comment.
Few improvements in implementation and integration tests.
Otherwise, LGTM.
mihirvala08
reviewed
Sep 11, 2025
Collaborator
|
/run-integration-tests 448e3a8 |
mihirvala08
approved these changes
Sep 12, 2025
Contributor
Author
|
Just curious why README examples were removed? Just so I don't add them on future changes. Appreciate it. |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forked off feature/rule_deploys