Skip to content

Fix swapped performance metrics in RetBleed benchmark table#396

Merged
matrizzo merged 1 commit into
google:masterfrom
2045castor:retbleed-readme-results
Jun 3, 2026
Merged

Fix swapped performance metrics in RetBleed benchmark table#396
matrizzo merged 1 commit into
google:masterfrom
2045castor:retbleed-readme-results

Conversation

@2045castor
Copy link
Copy Markdown
Contributor

This PR corrects a data entry error in the benchmark results table where the raw performance metrics (MEAN, MEDIAN, STDDEV) for "retbleed=off" and "retbleed=ibpb" were accidentally swapped.

The original table illogically showed the heaviest mitigation (ibpb) yielding the highest performance, while the unmitigated baseline (off) had the lowest. The correctness of this fix is verified by the existing Overhead column: calculating a 57.74 percent overhead from a true baseline of 91385.800 mathematically yields the 38619.000 result.

This commit simply maps the raw data back to the correct rows to align with the calculated overheads and expected hardware behavior.

@2045castor
Copy link
Copy Markdown
Contributor Author

@matrizzo Since you added the original documentation, could you take a quick look?

While studying this repository, I noticed that the performance data (MEAN, MEDIAN, STDDEV) for retbleed=off and retbleed=ibpb appear to be accidentally swapped in the benchmark table. The calculated Overhead percentages strongly support this.

Could you please review and confirm if this is the case? Thanks!

@matrizzo
Copy link
Copy Markdown
Collaborator

matrizzo commented Jun 3, 2026

Hi! It looks like the rows got mixed up somewhere, nice catch!

@matrizzo matrizzo merged commit 8f33fa8 into google:master Jun 3, 2026
5 checks passed
@2045castor 2045castor deleted the retbleed-readme-results branch June 3, 2026 14:56
@2045castor
Copy link
Copy Markdown
Contributor Author

Hi! It looks like the rows got mixed up somewhere, nice catch!

Thanks for the quick merge!

Since we're already fixing swapped metrics today, any chance we could accidentally swap the open and merged status for PR #380 too? 👀

(Jokes aside, would love a final look on that one whenever you have a moment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants