Skip to content

fix(deps): move lodash to dependencies#19

Merged
jpoehnelt merged 1 commit intojpoehnelt:masterfrom
kirintwn:fix-dependencies-lodash
Oct 8, 2020
Merged

fix(deps): move lodash to dependencies#19
jpoehnelt merged 1 commit intojpoehnelt:masterfrom
kirintwn:fix-dependencies-lodash

Conversation

@kirintwn
Copy link
Copy Markdown

@kirintwn kirintwn commented Oct 8, 2020

Since we utilize lodash in our source code, lodash should be listed in dependencies instead of devDependencies.
By doing so, we can use with npx, which doesn't install devDependencies:

npx \
  -p @semantic-release/commit-analyzer \
  -p @semantic-release/release-notes-generator \
  -p @semantic-release/changelog \
  -p @google/semantic-release-replace-plugin \
  -p @semantic-release/git \
  -p @semantic-release/github \
  -p semantic-release \
  semantic-release

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Oct 8, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kirintwn
Copy link
Copy Markdown
Author

kirintwn commented Oct 8, 2020

@googlebot I signed it!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           17        17           
  Branches         3         3           
=========================================
  Hits            17        17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7adfa...29fde96. Read the comment docs.

@jpoehnelt jpoehnelt merged commit 81c8098 into jpoehnelt:master Oct 8, 2020
@jpoehnelt
Copy link
Copy Markdown
Owner

Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2020

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants