Remove NV_EXTENSIONS conditionals#1003
Merged
Merged
Conversation
This has been removed from glslang a while ago and is no longer needed.
Contributor
Author
|
cc @dneto0 @s-perron @zoddicus This is a precursor for updating deps to include KHR_ray_tracing support (see KhronosGroup/Vulkan-Docs#1205) |
27 tasks
zoddicus
reviewed
Mar 18, 2020
Collaborator
zoddicus
left a comment
zoddicus
left a comment
There was a problem hiding this comment.
This looks reasonable to me. I have kicked off the Kokoro run to make sure that it doesn't need a dependency roll or anything. I will approve and land once the run is successful.
zoddicus
approved these changes
Mar 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been removed from glslang a while ago and is no longer needed.