Skip to content

Roll glslang dependency#1018

Merged
zoddicus merged 1 commit into
google:masterfrom
dgkoch:update_glslang
Mar 26, 2020
Merged

Roll glslang dependency#1018
zoddicus merged 1 commit into
google:masterfrom
dgkoch:update_glslang

Conversation

@dgkoch
Copy link
Copy Markdown
Contributor

@dgkoch dgkoch commented Mar 25, 2020

Roll third_party/glslang/ 1f0fcbe5a..8e26c5f50 (26 commits)

$ git log 1f0fcbe5a..8e26c5f50 --date=short --no-merges --format='%ad %ae %s'
2020-03-25 neslisah.torosdagli@amd.com switch format update
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com spirv.hpp reverted to commit f368dcbb7d8af23f0cba3015d0f4dda9dc3aa66d
2020-03-24 neslisah.torosdagli@amd.com .travis updated to origin, rayQueryCheck removed
2020-03-23 neslisah.torosdagli@amd.com const rayFlag defs used in the test cases in stead of numerical values
2020-03-23 neslisah.torosdagli@amd.com compute and fragment shader test_cases added for rayQuery
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases added
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT function parameter
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT assignment is allowed.
2020-03-23 neslisah.torosdagli@amd.com test names updated
2020-03-23 kainino@chromium.org update README
2020-03-23 kainino@chromium.org Fix build on CMake 2.8, and fix Web build
2020-03-23 neslisah.torosdagli@amd.com wait time increased for the install
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases disabled
2020-03-20 neslisah.torosdagli@amd.com GL_EXT_ray_query glslang updates, and test cases added.
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 neslisah.torosdagli@amd.com GL_EXT_ray_query updates
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates

Roll third_party/glslang/ 1f0fcbe5a..8e26c5f50 (26 commits)

$ git log 1f0fcbe5a..8e26c5f50 --date=short --no-merges --format='%ad %ae %s'
2020-03-25 neslisah.torosdagli@amd.com switch format update
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com copyright notice changes removed from unchanged files
2020-03-24 neslisah.torosdagli@amd.com spirv.hpp reverted to commit f368dcbb7d8af23f0cba3015d0f4dda9dc3aa66d
2020-03-24 neslisah.torosdagli@amd.com .travis updated to origin, rayQueryCheck removed
2020-03-23 neslisah.torosdagli@amd.com const rayFlag defs used in the test cases in stead of numerical values
2020-03-23 neslisah.torosdagli@amd.com compute and fragment shader test_cases added for rayQuery
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases added
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT function parameter
2020-03-23 neslisah.torosdagli@amd.com rayQueryEXT assignment is allowed.
2020-03-23 neslisah.torosdagli@amd.com test names updated
2020-03-23 kainino@chromium.org update README
2020-03-23 kainino@chromium.org Fix build on CMake 2.8, and fix Web build
2020-03-23 neslisah.torosdagli@amd.com wait time increased for the install
2020-03-23 neslisah.torosdagli@amd.com rayQuery test cases disabled
2020-03-20 neslisah.torosdagli@amd.com GL_EXT_ray_query glslang updates, and test cases added.
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
2020-03-18 cepheus@frii.com Fix #2132: constant matrix constructor from single non-scalar argument
2020-03-19 neslisah.torosdagli@amd.com comment update, rayQueryEXT is writable, readonly check removed.
2020-03-19 neslisah.torosdagli@amd.com GL_EXT_ray_query updates
2020-03-19 ntorosda@amd.com GL_EXT_ray_query updates
@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 25, 2020

cc @zoddicus @dneto0

This picks up ray query support in glslang.

@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 25, 2020

Is there also a known_good file? (I'm trying to figure out if I also need to do something like #1006, but I can't find that anymore...)

@zoddicus
Copy link
Copy Markdown
Collaborator

I believe that is just for the NDK. dneto0@ ?

@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 25, 2020

I believe that is just for the NDK. dneto0@ ?

I want to make sure the Khronos SDK update picks it up.

@zoddicus zoddicus requested a review from dneto0 March 25, 2020 18:54
@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 25, 2020

CI has passed.

@zoddicus
Copy link
Copy Markdown
Collaborator

@dneto0, can you comment if there is anything else that needs to be done?

@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 26, 2020

I think this is necessary, but it may not be sufficient. might as well get it in?
I think the known_good stuff needs to go in a separate branch, and probably has some testing procedure that is not accessible to me.

@zoddicus zoddicus merged commit ae50f26 into google:master Mar 26, 2020
@dgkoch dgkoch deleted the update_glslang branch March 26, 2020 14:16
@dgkoch
Copy link
Copy Markdown
Contributor Author

dgkoch commented Mar 26, 2020

Thanks!

@zoddicus zoddicus removed their request for review January 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants