-
Notifications
You must be signed in to change notification settings - Fork 328
Open
Labels
Good First IssueGood first issue for new engineersGood first issue for new engineersP0High priorityHigh priorityTeam SIssues for Squad 1Issues for Squad 1Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
Clicking on the user menu doesn't close the tooltip pointing to it:
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- Any user tooltip that points to the user menu should be closed when the user menu is opened.
Implementation Brief
- In
assets/js/components/UserMenu/index.js:- Within the
handleMenucallback, extract theclassNameusing thecore/uigetValueselector for theadmin-screen-tooltip. - If the className is
googlesitekit-tour-tooltip--user-menu, then dismiss the tooltip by callingsetValueon the same tooltip slug and setting it toundefined.- Only dismiss when opening the menu (
!menuOpen) and when the tooltip is actually visible and targeting the user menu (isTooltipVisible && className === 'googlesitekit-tour-tooltip--user-menu')
- Only dismiss when opening the menu (
- Within the
Test Coverage
- No new tests required.
QA Brief
- Reset Site Kit or on a site where Email reports isn't set up, reload the dashboard until the Email Reporting Overlay Notification appears.
- Click on Maybe later to ensure the tooltip to the user menu is displayed. Now click on the user menu and ensure the tooltip is automatically closed without any errors.
- Test the tooltip behaviour for other features like Ads, Audience Segmentation etc to ensure nothing else is broken.
Changelog entry
- Update the user menu component to close the user tooltip when the menu is opened.
Metadata
Metadata
Assignees
Labels
Good First IssueGood first issue for new engineersGood first issue for new engineersP0High priorityHigh priorityTeam SIssues for Squad 1Issues for Squad 1Type: EnhancementImprovement of an existing featureImprovement of an existing feature