Skip to content

Opening the user menu should close the tooltip pointing to it. #11956

@benbowler

Description

@benbowler

Feature Description

Clicking on the user menu doesn't close the tooltip pointing to it:

Image

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Any user tooltip that points to the user menu should be closed when the user menu is opened.

Implementation Brief

  • In assets/js/components/UserMenu/index.js:
    • Within the handleMenu callback, extract the className using the core/ui getValue selector for the admin-screen-tooltip.
    • If the className is googlesitekit-tour-tooltip--user-menu, then dismiss the tooltip by calling setValue on the same tooltip slug and setting it to undefined.
      • Only dismiss when opening the menu (!menuOpen) and when the tooltip is actually visible and targeting the user menu (isTooltipVisible && className === 'googlesitekit-tour-tooltip--user-menu')

Test Coverage

  • No new tests required.

QA Brief

  • Reset Site Kit or on a site where Email reports isn't set up, reload the dashboard until the Email Reporting Overlay Notification appears.
  • Click on Maybe later to ensure the tooltip to the user menu is displayed. Now click on the user menu and ensure the tooltip is automatically closed without any errors.
  • Test the tooltip behaviour for other features like Ads, Audience Segmentation etc to ensure nothing else is broken.

Changelog entry

  • Update the user menu component to close the user tooltip when the menu is opened.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Good First IssueGood first issue for new engineersP0High priorityTeam SIssues for Squad 1Type: EnhancementImprovement of an existing feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions