Draft
Conversation
|
This PR (HEAD: 2328921) has been imported to Gerrit for code review. Please visit review.skia.org/1123497 to see it. Please CC yourself to the Gerrit change. Note:
|
theoparis
force-pushed
the
push-wnvntmnqzvkx
branch
from
2328921 to
8a5b71f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes building Skia with Bazel 9 and 10. I marked it as a draft PR because emsdk needs some changes to fix
bazel test "//src/gpufor example and I'm waiting on the 9.0.0 release.Also, https://github.com/bazelbuild/rules_webtesting is archived and I had to temporarily remove it from the build files. I'm not sure what the replacement for this would be.