Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Oct 4, 2016

The current 5 year old settings file has several issues. E.g.:

  1. The ident options for Java are not imported correctly. They still remain the default settings after import (most likely due to missing codeStyleSettings block for java language).
  2. Import statement settings differ completely from written import statement order and using of blank lines (just two blocks, no empty lines within these blocks).

I have imported the settings for Eclipse in IntelliJ and adjusted some settings to fit the written style guide. This may not cover all issues but at least there is no longer a massive change of the file when you format the file in Eclipse and afterwards in IntelliJ IDEA Ultimate 2016.

The current 5 year old settings file has several issues. E.g.:
1) The ident options for Java are not imported correctly. They still remain the default settings after import (most likely due to missing codeStyleSettings block for java language).
2) Import statement settings differ completely from written import statement order and using of blank lines (just two blocks, no empty lines within these blocks).

I have imported the settings for Eclipse in IntelliJ and adjusted some settings to fit the written style guide. This may not cover all issues but at least there is no longer a massive change of the file when you format the file in Eclipse and afterwards in IntelliJ IDEA Ultimate 2016.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ghost
Copy link
Author

ghost commented Oct 4, 2016

I signed it

Mit freundlichen Grüßen,
Volker Schmidt

IT Services VS GmbH
Deutschherrnufer 49
60594 Frankfurt am Main

Telefon +49 69 17537580 0
Telefax +49 69 17537580 9
Mobil +49 151 61332026
E-Mail volker.schmidt@itsvs.de

Sitz der Gesellschaft ist Frankfurt am Main,
HRB 85532 Amtsgericht Frankfurt am Main,
Geschäftsführer Volker Schmidt,
USt-IdNr. DE265266568

Von: googlebot notifications@github.com
Antworten an: google/styleguide reply@reply.github.com
Datum: Dienstag, 4. Oktober 2016 um 20:12
An: google/styleguide styleguide@noreply.github.com
Cc: Volker Schmidt volker.schmidt@itsvs.de, Author author@noreply.github.com
Betreff: Re: [google/styleguide] Settings for IntelliJ IDEA Ultimate 2016 (#189)

I signed it

@afranken
Copy link

is this different from #142 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:java The Java language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants