-
Notifications
You must be signed in to change notification settings - Fork 13k
Include run_prettify.js script and update all pre tags to use it #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
@tituswinters This change would need to be mirrored internally or else it will just get clobbered on the next push. FWIW, JS and Java already both serve this same script for colorizing. |
|
@shicks @tituswinters so, do you think this could be something worth to merge? Or do you have any other comments about this? |
|
Sorry about that - I don't monitor this repo closely since most of the traffic isn't relevant to me. Honestly, to resolve that we're looking at moving the C++ guide out of here and into the Abseil.io repository so that changes can be noticed more easily - it'll get converted to markdown in the process. So I don't feel strongly either way. |
|
@shicks @tituswinters any news about this? |
|
ping @pwnall since you've been active on this area recently. |
|
@manshreck owns the decision for this. I'm fine either way, like Titus. |
IMHO it would be nice to have the code snipped being colorized to (hopefully) make the code examples easier to read.
Turns out there is a Google project doing that :)
https://github.com/google/code-prettify
I've added this script + added prettyprint class to all <pre> tag so they get colorized.
Might be worth to do the same thing for <code> but IMHO it is less needed as those are smaller portion of code + not all <code> tags are cpp, so special care should be taken when specifying classes on those. So let's worry about this in a second step.