Conversation
1. Fix error in the way we checked out git refs. 2. Always query the origin git repo and ask it to resolve refs to hashes. Use this SHA as the hash/temp directory name so that we never fall behind the origin. 3. Use the actual dependency versions to determine the identity of an NPM install directory, instead of the label. 4. Simplify some code.
kevinpschaaf
approved these changes
Sep 10, 2020
Member
kevinpschaaf
left a comment
kevinpschaaf
left a comment
There was a problem hiding this comment.
I followed the numbered fixes you described in the code, although I'm probably not the best equipped to catch bugs in the change, so feel free to wait for cdata, either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the new git dependency swapping feature, and improves temp dir caching behavior.
Fix error in the way we checked out git refs.
Always query the origin git repo and ask it to resolve refs to hashes. Use this SHA as the hash/temp directory name so that we never fall behind the origin.
Use the actual dependency versions to determine the identity of an NPM install directory, instead of the label.
Write a special file to the temp directory when installation succeeds. If the next time, we find it's not there, we assume the installation failed and re-install from scratch.
Simplify some code.
Fixes #190