Fix deranged-related TryFrom ambiguity#515
Conversation
|
Rustfmt job failure and clippy job failure are both unrelated to this PR. Diff in /home/runner/work/tarpc/tarpc/tarpc/src/server/request_hook/before.rs:157:
impl<Req, First: BeforeRequest<Req>, Rest: BeforeRequestList<Req>> BeforeRequestList<Req>
for BeforeRequestCons<First, Rest>
{
- type Then<Next> = BeforeRequestCons<First, Rest::Then<Next>> where Next: BeforeRequest<Req>;
+ type Then<Next>
+ = BeforeRequestCons<First, Rest::Then<Next>>
+ where
+ Next: BeforeRequest<Req>;
fn then<Next: BeforeRequest<Req>>(self, next: Next) -> Self::Then<Next> {
let BeforeRequestCons(first, rest) = self;
Diff in /home/runner/work/tarpc/tarpc/tarpc/src/server/request_hook/before.rs:172:
}
impl<Req> BeforeRequestList<Req> for BeforeRequestNil {
- type Then<Next> = BeforeRequestCons<Next, BeforeRequestNil> where Next: BeforeRequest<Req>;
+ type Then<Next>
+ = BeforeRequestCons<Next, BeforeRequestNil>
+ where
+ Next: BeforeRequest<Req>;
fn then<Next: BeforeRequest<Req>>(self, next: Next) -> Self::Then<Next> {
BeforeRequestCons(next, BeforeRequestNil)error: the following explicit lifetimes could be elided: 'a
--> plugins/src/lib.rs:535:6
|
535 | impl<'a> ServiceGenerator<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `-D clippy::needless-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
|
535 - impl<'a> ServiceGenerator<'a> {
535 + impl ServiceGenerator<'_> {
|
Checking http v1.3.1
error: the following explicit lifetimes could be elided: 'a
--> plugins/src/lib.rs:811:6
|
811 | impl<'a> ToTokens for ServiceGenerator<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
811 - impl<'a> ToTokens for ServiceGenerator<'a> {
811 + impl ToTokens for ServiceGenerator<'_> {
| |
Head branch was pushed to by a user without write access
|
Would it be possible to get this in a crates.io release relatively soon? I expect a nontrivial fraction of tarpc users depend on the troublesome |
Summary: Upstream PR: google/tarpc#515 This is required in order to unblock {D71914596} Reviewed By: JakobDegen Differential Revision: D71914594 fbshipit-source-id: 345f5680770de172dac3da5ae2fd40e6cafabc65
Summary: Upstream PR: google/tarpc#515 This is required in order to unblock {D71914596} Reviewed By: JakobDegen Differential Revision: D71914594 fbshipit-source-id: 345f5680770de172dac3da5ae2fd40e6cafabc65
Done, let me know if you have any issues. Thanks! |
Summary: PR google/tarpc#515 has been published in tarpc version 0.36.0, so the patch from {D71914594} is no longer needed. Differential Revision: D71943918 fbshipit-source-id: 5bf610258cb86521666536d673a2c751f494f5c9
Summary: PR google/tarpc#515 has been published in tarpc version 0.36.0, so the patch from {D71914594} is no longer needed. Differential Revision: D71943918 fbshipit-source-id: 5bf610258cb86521666536d673a2c751f494f5c9
When building
tarpcin a build graph that also containsderanged, it fails to build. See upstream's related issue jhpratt/deranged#18.