Merged
Conversation
shaladdle
approved these changes
Mar 25, 2026
Collaborator
|
Looks like there's a clippy lint, otherwise lgtm! |
stepancheg
force-pushed
the
ditch-anyhow
branch
from
0db81d3 to
ca16ff6
Compare
Contributor
Author
|
Should be good now. |
tikue
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify how errors are printed on client and server.
And while on it, remove anyhow dependency in favor or simple error stack printing.
Implementation is taken from there https://github.com/hyperium/tonic/blob/master/tonic/src/transport/server/display_error_stack.rs . That code was written by me, so it's OK.
In this PR I kept original name
print_errrather than inlining it intoDisplayErrorStackto minimize the diff.