-
Notifications
You must be signed in to change notification settings - Fork 11
feat: Add secret redaction via TEST_SERVER_SECRETS #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| Copyright 2025 Google LLC | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package redact | ||
|
|
||
| import ( | ||
| "regexp" | ||
| "strings" | ||
| ) | ||
|
|
||
| // REDACTED is the string used to replace redacted secrets. | ||
| const REDACTED = "REDACTED" | ||
|
|
||
| // Redact holds the compiled regex for redacting secrets. | ||
| type Redact struct { | ||
| regex *regexp.Regexp | ||
| } | ||
|
|
||
| // NewRedact creates a new Redact instance with the given secrets. | ||
| func NewRedact(secrets []string) (*Redact, error) { | ||
| filteredSecrets := []string{} | ||
| for _, secret := range secrets { | ||
| if secret != "" { | ||
| filteredSecrets = append(filteredSecrets, regexp.QuoteMeta(secret)) | ||
| } | ||
| } | ||
|
|
||
| if len(filteredSecrets) == 0 { | ||
| return &Redact{regex: nil}, nil // No secrets to redact | ||
| } | ||
|
|
||
| regexPattern := strings.Join(filteredSecrets, "|") | ||
| re, err := regexp.Compile(regexPattern) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return &Redact{regex: re}, nil | ||
| } | ||
|
|
||
| // Headers redacts the secrets in the values of the http.Header. | ||
| func (r *Redact) Headers(headers map[string][]string) { | ||
| if r == nil || r.regex == nil { | ||
| return // No redactor or no secrets configured | ||
| } | ||
| for name, values := range headers { | ||
| for i, value := range values { | ||
| headers[name][i] = r.regex.ReplaceAllString(value, REDACTED) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // String redacts the secrets in the input string. | ||
| func (r *Redact) String(input string) string { | ||
| if r == nil || r.regex == nil { | ||
| return input // No redactor or no secrets configured | ||
| } | ||
| return r.regex.ReplaceAllString(input, REDACTED) | ||
| } | ||
|
|
||
| // Bytes redacts the secrets in the input byte slice. | ||
| func (r *Redact) Bytes(input []byte) []byte { | ||
| if r == nil || r.regex == nil { | ||
| return input // No redactor or no secrets configured | ||
| } | ||
| if input == nil { | ||
| return nil // Return nil if input is nil | ||
| } | ||
| return r.regex.ReplaceAll(input, []byte(REDACTED)) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are line 104 and 106 duplicate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, the previous line here was actually redacting headers by key, fixed.