Skip to content

Conversation

@aplanas
Copy link
Contributor

@aplanas aplanas commented Jul 2, 2018

The test testNestedMatching compares a list of dictionaries with
a string. In Python 2 (and some versions of Python 3) the order
of a dictionary is not guaranteed, and this makes the test to fail.

This patch compares the raw result with the raw list, and assetEqual
takes care of the ordering.

The test `testNestedMatching` compares a list of dictionaries with
a string.  In Python 2 (and some versions of Python 3) the order
of a dictionary is not guaranteed, and this makes the test to fail.

This patch compares the raw result with the raw list, and assetEqual
takes care of the ordering.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@aplanas
Copy link
Contributor Author

aplanas commented Jul 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@buxtronix buxtronix merged commit 0f91e4d into google:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants