Skip to content

Remove torch.cholesky overrides#99

Merged
qihqi merged 3 commits into
google:mainfrom
malfet:patch-1
Jul 3, 2026
Merged

Remove torch.cholesky overrides#99
qihqi merged 3 commits into
google:mainfrom
malfet:patch-1

Conversation

@malfet

@malfet malfet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

torch.cholesky has been an alias for torch.linalg.cholesky for several years and is getting removed by pytorch/pytorch#186817

Update the repo to use torch.linalg.cholesky

Add torch.cholesky to skiplist, but check that torch.linalg.cholesky tests are still running

% python test/test_ops.py -v -k cholesky                                                              
op_db size:  697 testing:  657
test_reference_eager_cholesky_inverse_cpu_float32 (__main__.TestOpInfoCPU.test_reference_eager_cholesky_inverse_cpu_float32) ... ok
test_reference_eager_linalg_cholesky_cpu_float32 (__main__.TestOpInfoCPU.test_reference_eager_linalg_cholesky_cpu_float32) ... ok
test_reference_eager_linalg_cholesky_ex_cpu_float32 (__main__.TestOpInfoCPU.test_reference_eager_linalg_cholesky_ex_cpu_float32) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.788s

OK

@google-cla

google-cla Bot commented Jun 15, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@qihqi qihqi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@qihqi

qihqi commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Hi @malfet please click the cla/google link in the CI section and fill the form. Thanks!

malfet added 2 commits June 15, 2026 14:02
`torch.cholesky` has been an alias for `torch.linalg.cholesky` for several years and is getting removed by pytorch/pytorch#186817

Update the repo to use `torch.linalg.cholesky`
@malfet

malfet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

@qihqi please have another look, force pushed a change that re-authored both commits under non-temp email, otherwise CLA would not pass.

@qihqi

qihqi commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@malfet looks there is a lint issue.

@malfet

malfet commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@qihqi sorry, forgot about 2 spaces, should be done now (I hope CLA does not need to be re-signed right now)

@qihqi qihqi merged commit ac59e3d into google:main Jul 3, 2026
10 checks passed
@qihqi

qihqi commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Merged, sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants