Remove torch.cholesky overrides#99
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @malfet please click the cla/google link in the CI section and fill the form. Thanks! |
`torch.cholesky` has been an alias for `torch.linalg.cholesky` for several years and is getting removed by pytorch/pytorch#186817 Update the repo to use `torch.linalg.cholesky`
|
@qihqi please have another look, force pushed a change that re-authored both commits under non-temp email, otherwise CLA would not pass. |
|
@malfet looks there is a lint issue. |
|
@qihqi sorry, forgot about 2 spaces, should be done now (I hope CLA does not need to be re-signed right now) |
|
Merged, sorry about the delay! |
torch.choleskyhas been an alias fortorch.linalg.choleskyfor several years and is getting removed by pytorch/pytorch#186817Update the repo to use
torch.linalg.choleskyAdd
torch.choleskyto skiplist, but check thattorch.linalg.choleskytests are still running