Expand model tests and fix gemma from_params parsing#828
Merged
copybara-service[bot] merged 1 commit intomainfrom Dec 3, 2025
Merged
Expand model tests and fix gemma from_params parsing#828copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
sizhit2,
tianshub and
wang2yn84
as code owners
copybara-service
bot
force-pushed
the
test_836404999
branch
from
69ec1a4 to
3ee632b
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_836404999
branch
from
3ee632b to
bb35109
Compare
- added more test coverage for the main functions in model test - current split function can cause a leading hyphen, which in the `from_params()` formatting will create incorrect naming and routing. Fixed the issues and added tests for future cases PiperOrigin-RevId: 839841260
copybara-service
bot
force-pushed
the
test_836404999
branch
from
bb35109 to
dd9b951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand model tests and fix gemma from_params parsing
from_params()formatting will create incorrect naming and routing. Fixed the issues and added tests for future cases