Adding support for gemma-X-*, llama-X-* naming similar to HF#876
Merged
copybara-service[bot] merged 1 commit intomainfrom Dec 15, 2025
Merged
Adding support for gemma-X-*, llama-X-* naming similar to HF#876copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
60db464 to
3cfef77
Compare
3cfef77 to
c78f0e6
Compare
c78f0e6 to
29c8cb0
Compare
29c8cb0 to
40c590f
Compare
40c590f to
2c30cf2
Compare
- current naming did not allow the `-` after model family for many gemma and llama families. added the support and matched the names as they appear on HF - expanded tests to check for model ids as they appear on HF (or substring of what they would be on HF) - updated `llama3_405b` to `llama3p1_405b` since that is the correct version PiperOrigin-RevId: 844901207
2c30cf2 to
0863146
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for gemma-X-, llama-X- naming similar to HF
-after model family for many gemma and llama families. added the support and matched the names as they appear on HFllama3_405btollama3p1_405bsince that is the correct version