Implement common helper functions for common formatting operations #135
Conversation
|
|
||
| "" | ||
| " @public | ||
| " Format lines in the current buffer via a formatter invoked by {cmd}. The |
There was a problem hiding this comment.
Perhaps document that {cmd} is something you can pass to maktaba#syscall#Create()? As it stands, I wasn't sure if this was requiring a Syscall object, and the cases above where you passed a list were bugs.
(also below.)
There was a problem hiding this comment.
Oh, good catch. It was a bug (but strangely wasn't caught by the tests… I'll need to investigate coverage there).
It actually does take a maktaba.Syscall… updated to clarify that and enforce.
There was a problem hiding this comment.
I mean, I think there's some advantage in being able to pass in anything that can be passed to syscall#Create(), since then we can pass a list in the simple case, and a Syscall object in the uncommon case?
There was a problem hiding this comment.
Oh yeah! Good idea, I forgot we made it that clever. And I guess it didn't fail tests because it wasn't broken. 🤦♂️
Updated to accept both.
Clarifies that the formatterhelper functions expect a maktaba.Syscall, enforces that, and fixes two formatters buildifier and rustfmt that didn't.
Creates helper functions for the boilerplate of common operations in formatter implementations:
codefmt#formatterhelpers#Format({cmd})andcodefmt#formatterhelpers#AttemptFakeRangeFormatting({startline}, {endline}, {cmd}). These make conventions more obvious and help any intentional differences from the most common boilerplate version stand out more obviously.