Add a test for error reporting for buildifier. #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbarnett
approved these changes
Mar 3, 2017
Contributor
dbarnett
left a comment
dbarnett
left a comment
There was a problem hiding this comment.
Thanks! LGTM w/ one nit.
vroom/buildifier.vroom
Outdated
|
|
||
| @clear | ||
| % #<CR> | ||
| |java_package(]) |
Contributor
There was a problem hiding this comment.
Nit: I think it's clearer as
% #<CR>
% java_package(])
like https://github.com/google/vroom/blob/master/examples/buffer.vroom does. I had to think more about the vroom syntax in the line continuation form.
Member
Author
There was a problem hiding this comment.
Done (I was confused a bit as well), though note that the prevailing style in some of the other test files is for the continuation versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.