Implement maktaba#log#GetFormattedEntries and support 1-arg handler #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes help log handlers treat log entries as opaque data structures so maktaba can evolve the format as needed w/o having to coordinate versioning with callers. Entry format will be changed slightly in #103 after callers have a chance to migrate to this helper.
malcolmr
approved these changes
May 1, 2017
autoload/maktaba/log.vim
Outdated
| endtry | ||
| return printf('%s %s [%s] %s', | ||
| \ l:level_name, | ||
| \ strftime('%Y-%m-%d@%H:%M:%S', l:timestamp), |
There was a problem hiding this comment.
Consider using an ISO 8601 local date/time pattern? (e.g. '%Y-%m-%dT%H:%M:%S')?
dbarnett
force-pushed
the
log_formatentries
branch
from
3b84c2d to
1fb508a
Compare
dbarnett
added a commit
that referenced
this pull request
May 8, 2017
Changes since 1.14.0: * Implement maktaba#buffer#GetVisualSelection helper (#132). * Implement maktaba#log#GetFormattedEntries and support 1-arg log handler (see #204). * Notify user for messages logged at WARN or above by default (#185). * Fix Syscall.CallAsync failing for complex commands (#205). * Preserve trailing slash in maktaba#path#Split and MakeRelative (#137 and #175). * Fix 'maxfuncdepth' error in maktaba#json#Parse corner case (#153).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes help log handlers treat log entries as opaque data structures so maktaba can evolve the format as needed w/o having to coordinate versioning with callers. Entry format will be changed slightly in #103 after callers have a chance to migrate to this helper.
Note the "Not enough arguments" fallback could conceivably cause performance regressions until the callers are updated if there's a ton of logging, but I tried it out on a fairly heavy vim configuration with a lot of plugins and logging and I couldn't measure a reliable performance regression comparing
time vim -c quitoutput with and without.