This repository was archived by the owner on Jun 25, 2025. It is now read-only.
Conversation
|
|
||
| // Clean up before each test | ||
| beforeEach(done => rimraf(TEST_OUTPUT_PATH, done)); | ||
| beforeEach(done => del(TEST_OUTPUT_PATH + '/**').then(() => done(), done)); |
Contributor
There was a problem hiding this comment.
Why is there .then(() => done(), done) instead of .then(done, done)?
Contributor
There was a problem hiding this comment.
nvm. Got it. done(something) is for errors, isn’t it?
Author
|
@surma fixed the tests - sorry for the delay with that |
Contributor
|
@gauntface LGTM. I think we should include this, so merge at will. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@surma thoughts on this? Still worth doing?