Skip to content
This repository was archived by the owner on Jun 25, 2025. It is now read-only.

Comments

upgrade to mdl 1.1.3 and change locations as well#877

Merged
addyosmani merged 1 commit intogoogle:masterfrom
akkumar:rightpath
Jun 23, 2016
Merged

upgrade to mdl 1.1.3 and change locations as well#877
addyosmani merged 1 commit intogoogle:masterfrom
akkumar:rightpath

Conversation

@akkumar
Copy link
Contributor

@akkumar akkumar commented Jun 23, 2016

Change the path of mdl libraries as per the getting started guide here - https://getmdl.io/started/ .

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Garbee
Copy link
Contributor

Garbee commented Jun 23, 2016

LGTM

@akkumar
Copy link
Contributor Author

akkumar commented Jun 23, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@addyosmani
Copy link
Contributor

LGTM2. Thanks!

@addyosmani addyosmani merged commit 128b2ef into google:master Jun 23, 2016
@akkumar akkumar deleted the rightpath branch June 24, 2016 02:54
@akkumar
Copy link
Contributor Author

akkumar commented Jun 24, 2016

Thanks @addyosmani , @Garbee . It would be a nice-to-have a 0.6.5 release with this version upgrade / location change though. FYI .

@Garbee
Copy link
Contributor

Garbee commented Jun 24, 2016

Nah, 1.1.3 has a major bug. We are about to push 1.1.4. So when that gets put here we'll slice a new release.

@addyosmani
Copy link
Contributor

SGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants