Conversation
This resolves an issue with the latest version of npm and npm workspaces and vsce, where vsce thinks that the root of the extension is the root of the workspace and adds too many files to the extension. It also forces us to be very deliberate about what files are included in the extension. Finally, it lets us separate out the package.json file that we use for scripts and devdependencies from the file we use to configure the extension, which means that we can give the extension an id that matches its github repo: google.wireit
aomarks
left a comment
aomarks
left a comment
There was a problem hiding this comment.
Looks like the Windows test timed out. Probably need to bump to 30 mins.
Upping the parallelism from 1 will probably help here, but I want to implement stdio exclusivity locking first, because the log is really hard to read otherwise. (This is where we only let one script emit to stdout/stderr at a time, and buffer the other ones).
| "activationEvents": [ | ||
| "onLanguage:json" | ||
| ], | ||
| "icon": "logo.png", |
There was a problem hiding this comment.
(Can't comment on the png).
What happened to the squiggly part of the logo?
There was a problem hiding this comment.
I cropped it out here, because the main place it's displayed is in a small square in the extension sidebar, and just the text is already crowded there.
Sidebar with different color schemes:
Full page (after clicking on the extension):
There was a problem hiding this comment.
Ah ok good call. We could work on an even better suited logo sometime in the future maybe (just the W?). This seems great for now.
2 participants
google.wireit