Conversation
When a script has a wireit config but not an entry in the scripts section, we should squiggle under the wireit config name if present. We also give it a different reason code, so that we don't supercede this error message with an error about a mising dependency, as that's confusing. The dependency is present more or less, it's just improperly set up, so it's more helpful to tell the user about that improper setup than to just say that we couldn't find the dep.
aomarks
approved these changes
May 11, 2022
| }) | ||
| ); | ||
|
|
||
| test.only( |
Member
Author
There was a problem hiding this comment.
Eep! Done
Also added an eslint pass to prevent this in the future and verified that it flagged this instance.
aomarks
requested changes
May 11, 2022
Member
aomarks
left a comment
aomarks
left a comment
There was a problem hiding this comment.
Sorry clicked wrong radio button, an only needs to be removed
aomarks
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a script has a wireit config but not an entry in the scripts section, we should squiggle under the wireit config name if present.
We also give it a different reason code, so that we don't supercede this error message with an error about a mising dependency, as that's confusing. The dependency is present more or less, it's just improperly set up, so it's more helpful to tell the user about that improper setup than to just say that we couldn't find the dep.