Conversation
rictic
approved these changes
Jun 14, 2022
augustjk
approved these changes
Jun 14, 2022
Collaborator
augustjk
left a comment
augustjk
left a comment
There was a problem hiding this comment.
Looks good. Do we have any need for the "workspaces" key in the package.json anymore?
Member
Author
It's still useful for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We weren't running Node 14 in CI for a while, because of a typo discovered by @augustjk. But in that time, we also created some problems:
The
vscode-extensionpackage dependencies weren't getting installed because npm 6 doesn't support workspaces. So I just moved those to top-leveldevDependencies.Some new tests that checked stderr too strictly. npm 6 spews more junk than 8.
Fixes #294