Reduce default worker count to 2x logical CPU core count#363
Merged
Conversation
aomarks
approved these changes
Jul 26, 2022
Member
aomarks
left a comment
aomarks
left a comment
There was a problem hiding this comment.
I agree being a little more conservative is a good idea given our experience with Lit monorepo CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing
4 * os.cpus().lengthseems a little too taxing on the system. When many tests are run in parallel, a test can take significantly longer causing it to hit timeouts that it otherwise would not have hit when run standalone, requiring increasing the timeout as seen here lit/lit#3182. Reducing to 2x seems more reasonable.Also updated the docs to say the default is a multiple of "logical CPU cores", which is the count of the number threads the OS sees the system can process, instead of just "CPUs" or "CPU cores", in line with Node's doc on what
os.cpus()returns.