Add multizarr opening#23
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
Looks great!
Consider adding a brief note advertising this in the README?
| author='Google LLC', | ||
| author_email='noreply@google.com', | ||
| install_requires=['numpy', 'xarray', 'zarr', 'tensorstore'], | ||
| install_requires=['numpy', 'xarray', 'zarr', 'tensorstore', 'dask'], |
There was a problem hiding this comment.
Let's keep Dask as optional for installing Xarray-Tensorstore -- just add a note that it's required to the docstring for open_concatenated_zarrs().
There was a problem hiding this comment.
I've reverted this back. I had the thought to add another option in extras_require, but I've left it for now unless you think otherwise
2 participants
Hi @shoyer, thanks for agreeing to review a PR for this. This addresses #12
This PR adds support to open multiple zarrs concatenated along a single dimension. I've tried to keep this as minimal as possible, and to adapt from the tests that are there already to cover this