-
Notifications
You must be signed in to change notification settings - Fork 234
DSLX assert_ne, etc. #4227
Copy link
Copy link
Open
Labels
dslxDSLX (domain specific language) implementation / front-endDSLX (domain specific language) implementation / front-endenhancementNew feature or requestNew feature or requesttestingTest-infrastructure relatedTest-infrastructure related
Metadata
Metadata
Assignees
Labels
dslxDSLX (domain specific language) implementation / front-endDSLX (domain specific language) implementation / front-endenhancementNew feature or requestNew feature or requesttestingTest-infrastructure relatedTest-infrastructure related
Type
Projects
Status
No status
What's hard to do? (limit 100 words)
DSLX unit tests only provide
assert_eq. Sometimes you don't know what value it should be but know its bounds or what it shouldn't be (e.g. no longer zero).Current best alternative workaround (limit 100 words)
Use something like
assert_eq(x != 0, true);. This is not as readable.Your view of the "best case XLS enhancement" (limit 100 words)
At least have some wider set of assertions, e.g. https://google.github.io/googletest/reference/assertions.html#boolean.
Rust has
assert_nebut the others were rejected...some discussion can be found at https://internals.rust-lang.org/t/reviving-rfc-1662-assert-lt-assert-le-assert-gt-assert-ge/12643