Skip to content

DSLX assert_ne, etc. #4227

@mikex-oss

Description

@mikex-oss

What's hard to do? (limit 100 words)

DSLX unit tests only provide assert_eq. Sometimes you don't know what value it should be but know its bounds or what it shouldn't be (e.g. no longer zero).

Current best alternative workaround (limit 100 words)

Use something like assert_eq(x != 0, true);. This is not as readable.

Your view of the "best case XLS enhancement" (limit 100 words)

At least have some wider set of assertions, e.g. https://google.github.io/googletest/reference/assertions.html#boolean.

Rust has assert_ne but the others were rejected...some discussion can be found at https://internals.rust-lang.org/t/reviving-rfc-1662-assert-lt-assert-le-assert-gt-assert-ge/12643

Metadata

Metadata

Assignees

No one assigned

    Labels

    dslxDSLX (domain specific language) implementation / front-endenhancementNew feature or requesttestingTest-infrastructure related

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions