With the introduction of the param token-and-data producing op from the non-synth pass, avoid token dependencies with it.#2866
Merged
copybara-service[bot] merged 1 commit intomainfrom Aug 15, 2025
Conversation
…he non-synth pass, avoid token dependencies with it. The non_synth_separation_pass separates out non-synthasizable nodes into a differnt function from the original. It does this for both procs and functions. In the situation that a non-synth function is made from a proc such that a receive return value is passed as a parameter to the new function, this param node is considered a token-and-data producing op, but the token_dependency_pass only supports receive token-and-data producing ops. This change makes it so the params are ignored in this case. PiperOrigin-RevId: 795579423
copybara-service
bot
force-pushed
the
test_794783753
branch
from
66d8b9a to
8cadc66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the introduction of the param token-and-data producing op from the non-synth pass, avoid token dependencies with it.
The non_synth_separation_pass separates out non-synthasizable nodes into a differnt function from the original. It does this for both procs and functions. In the situation that a non-synth function is made from a proc such that a receive return value is passed as a parameter to the new function, this param node is considered a token-and-data producing op, but the token_dependency_pass only supports receive token-and-data producing ops. This change makes it so the params are ignored in this case.