Properly handle const if expression when using proc-scoped channels#3745
Merged
copybara-service[bot] merged 2 commits intogoogle:mainfrom Feb 4, 2026
Merged
Properly handle const if expression when using proc-scoped channels#3745copybara-service[bot] merged 2 commits intogoogle:mainfrom
const if expression when using proc-scoped channels#3745copybara-service[bot] merged 2 commits intogoogle:mainfrom
Conversation
629d7a4 to
0a4d965
Compare
const if expression when using proc-scoped channelsconst if expression when using proc-scoped channels
Contributor
Author
|
I've included a fix for using the correct type info when traversing parametrized proc's hierarchy in |
richmckeever
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling proper branch from
const ifwhen converting DSLX to IR withlower_to_proc_scoped_channelsflag enabled. While it works on addedConstConditionalProcScopedtest case, it breaks when trying to get a constexpr value from thetestexpression ifconst ifis inside a parametric proc with the following error:This issue can be reproduced by trying to build the const_if_ir example with changes from this PR.