Avoid cloning invokes in strength reduction.#4107
Open
meheff wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
Strength reduction will sink operations into a select if the transformation can result in constant folding or dramtic simplification. This was previously guarded by OpIsSideEffecting. This change also prevents the transformation if the operation is an inoke as the invoked function may be side-effecting. This was resulting in inflooping of the optimizer with FFI functions. Invokes were being transformed, but the old dead invokes were not being DCE'd because dce doesn't remove invokes because they may result in side-effects. This change causes the optimizer to treat invokes as potentially side-effecting more consistently.
meheff
added a commit
to xlsynth/xlsynth
that referenced
this pull request
Apr 14, 2026
meheff
added a commit
to xlsynth/xlsynth
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strength reduction will sink operations into a select if the transformation can result in constant folding or dramatic simplification. This was previously guarded by OpIsSideEffecting. This change also prevents the transformation if the operation is an invoke as the invoked function may be side-effecting.
This change fixes inf-looping of the optimizer with FFI functions. Invokes were being transformed, but the old dead invokes were not being DCE'd because dce doesn't remove invokes because they may result in side-effects. This change causes the optimizer to treat invokes as potentially side-effecting more consistently.