[opt] Fix array_untuple bug by properly excluding unhandled node operands#4241
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_914322574
branch
from
faa5c63 to
64e0a03
Compare
…erands When an unhandled node (e.g. `invoke`) returned an array of tuples, the external-group-finding analysis in `ArrayUntuplePass` incorrectly skipped checking the node's operands due to an early continue. This caused unsupported array-of-tuples arguments passed to that node to remain eligible for untupling, resulting in broken state mutations and incorrect correctness outcomes. This change removes the early continue, ensuring that operands of all unhandled nodes are correctly identified and excluded from untupling, preserving package semantics. #geminiassisted PiperOrigin-RevId: 914673404
copybara-service
Bot
force-pushed
the
test_914322574
branch
from
64e0a03 to
03eca3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[opt] Fix
array_untuplebug by properly excluding unhandled node operandsWhen an unhandled node (e.g.
invoke) returned an array of tuples, the external-group-finding analysis inArrayUntuplePassincorrectly skipped checking the node's operands due to an early continue. This caused unsupported array-of-tuples arguments passed to that node to remain eligible for untupling, resulting in broken state mutations and incorrect correctness outcomes.This change removes the early continue, ensuring that operands of all unhandled nodes are correctly identified and excluded from untupling, preserving package semantics.
#geminiassisted