Get a simple use of a parametric ProcDef to typecheck successfully.#4276
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_916277674
branch
5 times, most recently
from
0955f15 to
b9c405f
Compare
Part of the problem being fixed here is type inference for chains like `S<T>::new(args).foo()`. This pattern was broken even for regular structs before this, due to e.g. improper differentiation of instance methods from static member functions, like new() in this example. PiperOrigin-RevId: 917916379
copybara-service
Bot
force-pushed
the
test_916277674
branch
from
b9c405f to
6069746
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get a simple use of a parametric ProcDef to typecheck successfully.
Part of the problem being fixed here is type inference for chains like
S<T>::new(args).foo(). This pattern was broken even for regular structs before this, due to e.g. improper differentiation of instance methods from static member functions, like new() in this example.