-
Notifications
You must be signed in to change notification settings - Fork 29
Remove linux from onDesktopUserAgent #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It was a hack back in days to quickly prototype ;) Would you double check Chrome user agent on launched Galaxy XR and make sure things are working without this? Thanks! |
|
Personally, I don't think we should be checking the user agent string at all. We should unify the behavior between devices or check for capabilities only. |
|
I agree that we shouldn't, yet have you checked simulator / WebXR runtime are automatically determined without this, Ideally, by default: all desktop: simulator only while developers can request to show two buttons for users to choose from. If you've checked already in the simulator logic, I'll LGTM. |
|
The current default behavior is desktops always launch simulator and mobile/android XR either show "Enter WebXR" or webxr unsupported. The simulator won't launch on Android XR unless the user enters webxr and then exits. |
|
As you requested, by default users can't enter webxr on desktop. |
|
To clarify, this PR is to allow the simulator to start on linux desktops instead of showing WebXR is not supported. |
|
Thanks for fixing my bug! I didn't make a good way to determine desktop at the very beginning. |
|
This is breaking all demos on Android XR. My bad for not testing before approving. |
No description provided.