Skip to content

Conversation

@dli7319
Copy link
Collaborator

@dli7319 dli7319 commented Nov 1, 2025

No description provided.

@dli7319 dli7319 marked this pull request as ready for review November 1, 2025 07:24
@dli7319 dli7319 requested a review from ruofeidu November 1, 2025 07:24
@ruofeidu
Copy link
Collaborator

ruofeidu commented Nov 1, 2025

It was a hack back in days to quickly prototype ;)
Are we checking if WebXR is available and have a better API to test what device user is running on?

Would you double check Chrome user agent on launched Galaxy XR and make sure things are working without this? Thanks!

@ruofeidu ruofeidu self-assigned this Nov 1, 2025
@dli7319
Copy link
Collaborator Author

dli7319 commented Nov 1, 2025

Personally, I don't think we should be checking the user agent string at all. We should unify the behavior between devices or check for capabilities only.

@ruofeidu
Copy link
Collaborator

ruofeidu commented Nov 1, 2025

I agree that we shouldn't, yet have you checked simulator / WebXR runtime are automatically determined without this,
by checking availability of APIs?

Ideally, by default:

all desktop: simulator only
all phone / Android XR: WebXR only

while developers can request to show two buttons for users to choose from.

If you've checked already in the simulator logic, I'll LGTM.

@dli7319
Copy link
Collaborator Author

dli7319 commented Nov 1, 2025

The current default behavior is desktops always launch simulator and mobile/android XR either show "Enter WebXR" or webxr unsupported. The simulator won't launch on Android XR unless the user enters webxr and then exits.

@dli7319
Copy link
Collaborator Author

dli7319 commented Nov 1, 2025

As you requested, by default users can't enter webxr on desktop.

@dli7319
Copy link
Collaborator Author

dli7319 commented Nov 1, 2025

To clarify, this PR is to allow the simulator to start on linux desktops instead of showing WebXR is not supported.

@ruofeidu
Copy link
Collaborator

ruofeidu commented Nov 2, 2025

Thanks for fixing my bug! I didn't make a good way to determine desktop at the very beginning.

@ruofeidu ruofeidu merged commit e019665 into google:main Nov 2, 2025
4 checks passed
@ruofeidu
Copy link
Collaborator

ruofeidu commented Nov 4, 2025

This is breaking all demos on Android XR. My bad for not testing before approving.
For future releases, let's have at least two people try out all templates and basic samples :)

@ruofeidu ruofeidu added the bug Something isn't working label Nov 4, 2025
@dli7319 dli7319 deleted the linux branch November 4, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants