Make CI keep pre-commit hooks up to date#1097
Merged
bwendling merged 1 commit intogoogle:mainfrom Jun 13, 2023
Merged
Conversation
hartwork
changed the title
Spitfire1900
approved these changes
May 27, 2023
Contributor
Author
|
@Spitfire1900 thanks! 🙏 |
hartwork
changed the title
Contributor
Author
|
@bwendling how do you feel about this? |
Contributor
Author
|
@bwendling how do you feel about this, any concerns? |
Member
|
This is good. Thank you. I'm sorry for the late reply. I've been on leave this month for family stuff. I made sure the GitHub Actions permissions are what you specified above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was split off of #1096 as suggested at #1096 (comment) .
I'm using a 99% identical approach at multiple other places happily, e.g. pull request hartwork/git-delete-merged-branches#132 was created the same way, also git-big-picture/git-big-picture#318 and so on.
If you like this approach: after the merge, if you trigger workflow
pre_commit_autoupdatemanually it will create a pull request updating the isort pre-commit hook tov4.4.0for us. If you don't, it will do that next Friday.For the CI to be able to create pull requests, this setting on the repository is needed:
Let me know what you think 🍻
CC @bwendling @Spitfire1900