Flake8 fails unnecessarily if run before yapf#1099
Merged
thiagowfx merged 4 commits intogoogle:mainfrom Jun 7, 2023
Spitfire1900:flake8-fails-unnecessarily-if-run-before-yapf
Merged
Flake8 fails unnecessarily if run before yapf#1099thiagowfx merged 4 commits intogoogle:mainfrom Spitfire1900:flake8-fails-unnecessarily-if-run-before-yapf
thiagowfx merged 4 commits intogoogle:mainfrom
Spitfire1900:flake8-fails-unnecessarily-if-run-before-yapf
Conversation
…, local repo does not perform an install This reverts commit f85b867.
Contributor
Author
|
CC @hartwork |
hartwork
approved these changes
May 31, 2023
Contributor
hartwork
left a comment
hartwork
left a comment
There was a problem hiding this comment.
@Spitfire1900 good idea! 👍
Contributor
Author
|
CC'ing @bwendling and @thiagowfx for review. |
thiagowfx
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake8 running before yapf causes the flake8 hook to fail unnecessarily for some cases that would have been auto-fixed by yapf.