Add in_place argument to FormatFile.#158
Merged
bwendling merged 1 commit intogoogle:masterfrom Jun 17, 2015
Merged
Conversation
(For use as a module.) Corrects the docstring of FormatCode to say that it raises if there is an IOError. Previously this claimed it returned (None, encoding) which was not correct. Now (None, encoding) is used if the FormatFile was used with in_place.
Contributor
Author
|
@gwelymernans Fixed. (As you can see our previous discussion has been wiped from the PR!) |
Member
|
Oy! That is a nasty bug... |
bwendling
added a commit
that referenced
this pull request
Jun 17, 2015
Add in_place argument to FormatFile.
hayd
added a commit
to hayd/yapf
that referenced
this pull request
Jun 17, 2015
Also fix a typo from updating the README in google#157. Note: in_place argument introduced in google#158.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(For use as a module.)