Skip to content

Conversation

@Aditya-PS-05
Copy link
Contributor

closes #2014

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c72fcbf). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2015   +/-   ##
=======================================
  Coverage        ?   89.46%           
=======================================
  Files           ?       16           
  Lines           ?     5838           
  Branches        ?        0           
=======================================
  Hits            ?     5223           
  Misses          ?      615           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf
Copy link
Member

joshlf commented Nov 4, 2024

Thanks for this! I think it should be possible to mostly just re-use the existing release-crate-version.yml workflow rather than having to re-invent the wheel, so I took a stab at that in #2017. I'm going to test that and see if it does what we need it to - if not, I'll revisit this PR since we may need the complexity in this PR if it turns out that you can't just do it using the simpler approach.

@Aditya-PS-05
Copy link
Contributor Author

@joshlf , okay. From my side, I will once try to reuse the existing code and decrease the complexity.

@Aditya-PS-05
Copy link
Contributor Author

Thanks for this! I think it should be possible to mostly just re-use the existing release-crate-version.yml workflow rather than having to re-invent the wheel, so I took a stab at that in #2017. I'm going to test that and see if it does what we need it to - if not, I'll revisit this PR since we may need the complexity in this PR if it turns out that you can't just do it using the simpler approach.

Thanks, if you find any another issues, please tell me I would love to contribute.

@joshlf
Copy link
Member

joshlf commented Nov 5, 2024

Confirmed that the simpler approach in #2017 works as needed. Thanks again for putting this up, though!

@joshlf joshlf closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create GitHub Action to automatically back-port PRs between branches

3 participants