Skip to content

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Jan 16, 2026

Use the Ctx type to carry the DeriveInput and zerocopy_crate: Path
values which are used by most functions.


Latest Update: v6 — Compare vs v5

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v5 v4 v3 v2 v1 Base
v6 vs v5 vs v4 vs v3 vs v2 vs v1 vs Base
v5 vs v4 vs v3 vs v2 vs v1 vs Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring to the zerocopy-derive crate by implementing a new Ctx struct. This struct serves as a central container for the DeriveInput and the zerocopy_crate path, which are commonly used throughout the derive macro implementation. By consolidating these frequently accessed values into a single context object, the change aims to simplify function signatures, enhance code readability, and improve the overall maintainability of the macro's internal logic.

Highlights

  • Introduced Ctx Struct: A new Ctx struct is added to centralize DeriveInput and the zerocopy_crate path, which were previously passed as separate arguments to many functions.
  • Simplified Function Signatures: Many internal helper functions now accept a single &Ctx parameter, reducing argument clutter and improving readability.
  • Improved Code Organization: The logic for extracting the zerocopy_crate path from attributes is now encapsulated within the Ctx::try_from_derive_input method, leading to better modularity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@joshlf joshlf requested a review from jswrenn January 16, 2026 19:52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Ctx type to bundle DeriveInput and zerocopy_crate path, which are frequently passed together. This is a great refactoring that simplifies many function signatures and improves code maintainability. The changes are applied consistently across the derive macro codebase. I have one minor suggestion to improve performance slightly by moving a variable assignment out of a loop. Overall, this is a solid improvement.

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (dae16a5) to head (6ebdd8e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2890   +/-   ##
=======================================
  Coverage   91.90%   91.90%           
=======================================
  Files          20       20           
  Lines        5877     5877           
=======================================
  Hits         5401     5401           
  Misses        476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshlf joshlf force-pushed the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch from 5b5202c to 9fa5e12 Compare January 16, 2026 19:56
@joshlf joshlf force-pushed the G3cfee091c2de68a64a643bafaf57c57427dd4914 branch from ed55ddf to 857dfdb Compare January 16, 2026 19:56
@joshlf joshlf force-pushed the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch from 9fa5e12 to c6141ac Compare January 16, 2026 20:21
@joshlf joshlf changed the base branch from G3cfee091c2de68a64a643bafaf57c57427dd4914 to Gcbfd20893d04c5245ea2adf3c1f4ef3ba2327ac6 January 16, 2026 20:21
@joshlf joshlf force-pushed the Gcbfd20893d04c5245ea2adf3c1f4ef3ba2327ac6 branch from afd2f14 to cd9f80a Compare January 16, 2026 20:26
Base automatically changed from Gcbfd20893d04c5245ea2adf3c1f4ef3ba2327ac6 to main January 16, 2026 21:10
@joshlf joshlf force-pushed the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch from c6141ac to 52dc827 Compare January 16, 2026 22:11
@joshlf joshlf changed the base branch from main to G3cfee091c2de68a64a643bafaf57c57427dd4914 January 16, 2026 22:11
@joshlf joshlf force-pushed the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch from 52dc827 to 9fcaf05 Compare January 17, 2026 00:51
@joshlf joshlf force-pushed the G3cfee091c2de68a64a643bafaf57c57427dd4914 branch from f96e8d5 to 9273914 Compare January 17, 2026 00:51
@joshlf joshlf force-pushed the G3cfee091c2de68a64a643bafaf57c57427dd4914 branch from 9273914 to 6621dbc Compare January 20, 2026 15:30
Base automatically changed from G3cfee091c2de68a64a643bafaf57c57427dd4914 to main January 20, 2026 16:11
Use the `Ctx` type to carry the `DeriveInput` and `zerocopy_crate: Path`
values which are used by most functions.

gherrit-pr-id: G0662505d5901f5c3cd21b16c314b9f3f8dc817a6
@joshlf joshlf force-pushed the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch from 9fcaf05 to 6ebdd8e Compare January 20, 2026 16:15
@joshlf joshlf enabled auto-merge January 20, 2026 16:16
@joshlf joshlf added this pull request to the merge queue Jan 20, 2026
Merged via the queue into main with commit f905feb Jan 20, 2026
215 of 222 checks passed
@joshlf joshlf deleted the G0662505d5901f5c3cd21b16c314b9f3f8dc817a6 branch January 20, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants