[test] Migrate from trybuild to ui-test#2986
Open
joshlf wants to merge 1 commit intoG793f61a136b912fbd5ee4315cdea7cf3cf3cf8fbfrom
Open
[test] Migrate from trybuild to ui-test#2986joshlf wants to merge 1 commit intoG793f61a136b912fbd5ee4315cdea7cf3cf3cf8fbfrom
joshlf wants to merge 1 commit intoG793f61a136b912fbd5ee4315cdea7cf3cf3cf8fbfrom
Conversation
Contributor
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's UI testing setup by switching from Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the UI testing framework from trybuild to ui-test, which is a great improvement for handling toolchain-specific test outputs. The changes look mostly correct, with a new test runner and reorganized test files. However, I've noticed a high-severity issue: the new .stderr files contain absolute local paths, which will break the build in CI and for other developers. These paths need to be normalized. I've also found some minor dead code in the new test harness. Please see my detailed comments.
joshlf
force-pushed
the
Gbc6b00b4dee88c0d25be0b277998861157eccda7
branch
5 times, most recently
from
0119dfe to
d817b95
Compare
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the UI testing framework from trybuild to a custom solution, which is a great improvement for testing across different Rust toolchains. The changes are mostly mechanical and look good. I've found a potential issue in the Cargo.toml workspace configuration and have a few other suggestions for improving code clarity and maintainability.
joshlf
force-pushed
the
Gbc6b00b4dee88c0d25be0b277998861157eccda7
branch
6 times, most recently
from
599c468 to
53d3f4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## G793f61a136b912fbd5ee4315cdea7cf3cf3cf8fb #2986 +/- ##
==========================================================================
Coverage 91.87% 91.87%
==========================================================================
Files 20 20
Lines 6057 6057
==========================================================================
Hits 5565 5565
Misses 492 492 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joshlf
force-pushed
the
Gbc6b00b4dee88c0d25be0b277998861157eccda7
branch
2 times, most recently
from
8c3ecbf to
2c2eb9d
Compare
joshlf
changed the base branch from
main
to
G793f61a136b912fbd5ee4315cdea7cf3cf3cf8fb
Closes #187 gherrit-pr-id: Gbc6b00b4dee88c0d25be0b277998861157eccda7
joshlf
force-pushed
the
G793f61a136b912fbd5ee4315cdea7cf3cf3cf8fb
branch
from
7e5f696 to
e5c4b11
Compare
joshlf
force-pushed
the
Gbc6b00b4dee88c0d25be0b277998861157eccda7
branch
from
2c2eb9d to
f17e706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187
impl_or_verify!tests todoctests#2988RUSTDOCFLAGS#2987Latest Update: v16 — Compare vs v15
📚 Full Patch History
Links show the diff between the row version and the column version.
⬇️ Download this PR
Branch
git fetch origin refs/heads/Gbc6b00b4dee88c0d25be0b277998861157eccda7 && git checkout -b pr-Gbc6b00b4dee88c0d25be0b277998861157eccda7 FETCH_HEADCheckout
git fetch origin refs/heads/Gbc6b00b4dee88c0d25be0b277998861157eccda7 && git checkout FETCH_HEADCherry Pick
git fetch origin refs/heads/Gbc6b00b4dee88c0d25be0b277998861157eccda7 && git cherry-pick FETCH_HEADPull
Stacked PRs enabled by GHerrit.