Conversation
This patch modifies the `roll-pinned-prebuilts.py` script to detect the host platform and hook into the archive extraction phase to extract both the `charon` and `charon-driver` binaries. It executes `charon rustc -- --version` to query the rustc version compiled into Charon. It then parses this version and bumps the date by 1 day to construct the associated rustup `nightly-YYYY-MM-DD` toolchain tag. The parsed toolchain name is then populated into `package.metadata.build_rs.charon_rust_toolchain` in `Cargo.toml`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3172 +/- ##
=======================================
Coverage 91.85% 91.85%
=======================================
Files 20 20
Lines 6067 6067
=======================================
Hits 5573 5573
Misses 494 494 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closes #3165 |
Acknowledged. |
2 participants
Modify
roll-pinned-prebuilts.pyto automatically calculate and inject thecharon_rust_toolchainrequired by Charon.PR created automatically by Jules for task 10111134362258288229 started by @joshlf